On 11/30/21 12:43 AM, Bean Huo wrote:
On Fri, 2021-11-19 at 11:57 -0800, Bart Van Assche wrote:
+ return IRQ_HANDLED;
}
ufshcd_transfer_req_compl() will never return IRQ_NONE,
but ufshcd_intr() needs this return to check the fake interrupt.
I don't think that it is possible to implement polling and detect
spurious interrupts without affecting performance negatively. Hence
the choice to never return IRQ_NONE. Is spurious interrupt detection
that important or is this only required for debugging host controllers?
I consider helping with hardware debugging as out of scope for the UFS
driver.
@@ -9437,6 +9481,7 @@ int ufshcd_alloc_host(struct device *dev,
struct ufs_hba **hba_handle)
err = -ENOMEM;
goto out_error;
}
+ host->nr_maps = 3;
I don't understand why not directly uses HCTX_MAX_TYPES, 3 is already
maximum.
If new map types would be introduced in the future, we still need 3 maps.
Hence the choice for '3' instead of HCTX_MAX_TYPES.
Thanks,
Bart.
