Re: [PATCH 05/13] scsi: ata: Declare 'ata_ncq_sdev_attrs' static

Bart Van Assche <bvanassche@xxxxxxx> · Mon, 29 Nov 2021 11:37:39 -0800

On 11/24/21 12:54 AM, Damien Le Moal wrote:
On 2021/11/24 9:52, Bart Van Assche wrote:
Fix the following kernel-doc warning:

'ata_ncq_sdev_attrs' is only used in one source file. Hence declare this
array static.

Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
---
  drivers/ata/libata-sata.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index 4e88597aa9df..5b78e86e3459 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -922,7 +922,7 @@ DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR,
  	    ata_ncq_prio_enable_show, ata_ncq_prio_enable_store);
  EXPORT_SYMBOL_GPL(dev_attr_ncq_prio_enable);
  
-struct attribute *ata_ncq_sdev_attrs[] = {
+static struct attribute *ata_ncq_sdev_attrs[] = {
  	&dev_attr_unload_heads.attr,
  	&dev_attr_ncq_prio_enable.attr,
  	&dev_attr_ncq_prio_supported.attr,


Already fixed in rc2.
See commit cac7e8b5f5fa94e28d581fbb9e76cb1c0c7fd56a.

Hi Damien,

Thanks for the feedback. I remembered that I had seen an ATA fix but couldn't
find it while I was preparing this series ...

Bart.






