Re: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable

[Florian Fainelli <f.fainelli@xxxxxxxxx>]

On 11/26/2021 12:52 AM, Manish Rangankar wrote:
> > -----Original Message-----
> > From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Sent: Friday, November 26, 2021 10:45 AM
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>; kernel test robot <lkp@xxxxxxxxx>;
> > Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar
> > <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-Upstream <GR-QLogic-
> > Storage-Upstream@xxxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxx>;
> > Martin K. Petersen <martin.petersen@xxxxxxxxxx>; open list:QLOGIC QL41xxx
> > ISCSI DRIVER <linux-scsi@xxxxxxxxxxxxxxx>
> > Subject: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > The variable page is set but never used throughout qedi_alloc_bdq() therefore
> > remove it.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > ---
> >   drivers/scsi/qedi/qedi_main.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> > 1dec814d8788..f1c933070884 100644
> > --- a/drivers/scsi/qedi/qedi_main.c
> > +++ b/drivers/scsi/qedi/qedi_main.c
> > @@ -1538,7 +1538,6 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
> >   	int i;
> >   	struct scsi_bd *pbl;
> >   	u64 *list;
> > -	dma_addr_t page;
> >
> >   	/* Alloc dma memory for BDQ buffers */
> >   	for (i = 0; i < QEDI_BDQ_NUM; i++) {
> > @@ -1608,11 +1607,9 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
> >   	qedi->bdq_pbl_list_num_entries = qedi->bdq_pbl_mem_size /
> >   					 QEDI_PAGE_SIZE;
> >   	list = (u64 *)qedi->bdq_pbl_list;
> > -	page = qedi->bdq_pbl_list_dma;
> >   	for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
> >   		*list = qedi->bdq_pbl_dma;
> >   		list++;
> > -		page += QEDI_PAGE_SIZE;
> >   	}
> >
> >   	return 0;
> > --
> > 2.25.1
>
> Thanks,
> Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>

Thanks for taking a look, does not that make the loop iterating the list 
even more useless now, though? Should not page have been used for 
something in that function?
--
Florian