On 11/25/21 19:21, Randy Dunlap wrote:
Fixes: f8ab27d96494 ("scsi: esp_scsi: Call scsi_done() directly")
The build robot reported link failures for many more functions than scsi_done() so I do not agree with the above line.
--- linux-next-20211125.orig/drivers/scsi/Kconfig +++ linux-next-20211125/drivers/scsi/Kconfig @@ -1296,7 +1296,7 @@ source "drivers/scsi/arm/Kconfig"config JAZZ_ESPbool "MIPS JAZZ FAS216 SCSI support" - depends on MACH_JAZZ && SCSI + depends on MACH_JAZZ && SCSI=y select SCSI_SPI_ATTRS help This is the driver for the onboard SCSI host adapter of MIPS Magnum
There are many more similar entries in drivers/scsi. Why to modify only one entry instead of modifying them all?
Additionally, to me it seems that the root cause is in the kbuild infrastructure instead of in drivers/scsi/Kconfig. From Documentation/kbuild/kconfig-language.rst about "select <symbol>": "The value of the current menu symbol is used as the minimal value <symbol> can be set to."
The build errors are the result of the combination JAZZ_ESP=y and SCSI_SPI_ATTRS=m. Since that combination is not allowed according to the kbuild documention, I think the kbuild infrastructure should be fixed.
Thanks, Bart.
