On Tue, 2007-05-29 at 13:00 -0500, Brian King wrote:
> Adds support for a changeable queue depth to ibmvscsi.
>
> Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>
> ---
>
> linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_change_q_depth drivers/scsi/ibmvscsi/ibmvscsi.c
> --- linux-2.6/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_change_q_depth 2007-05-29 09:31:43.000000000 -0500
> +++ linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c 2007-05-29 09:31:43.000000000 -0500
> @@ -1375,6 +1375,20 @@ static int ibmvscsi_slave_configure(stru
> return 0;
> }
>
> +/**
> + * ibmvscsi_change_queue_depth - Change the device's queue depth
> + * @sdev: scsi device struct
> + * @qdepth: depth to set
> + *
> + * Return value:
> + * actual depth set
> + **/
> +static int ibmvscsi_change_queue_depth(struct scsi_device *sdev, int qdepth)
> +{
> + scsi_adjust_queue_depth(sdev, 0, qdepth);
Don't you want to check this against some system limit ... or will the
driver cope just fine when the user sets it to machine infinity and we
diligently try blasting away at it through the queuecommand() routine?
The usual limit, if you have variable queues ... is the maximum the
device could ever accept ... although some people adjust that downwards
because of device starvation fears.
> + return sdev->queue_depth;
> +}
James
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
