> -----Original Message----- > From: Florian Fainelli <f.fainelli@xxxxxxxxx> > Sent: Friday, November 26, 2021 10:45 AM > To: linux-kernel@xxxxxxxxxxxxxxx > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>; Nilesh Javali <njavali@xxxxxxxxxxx>; > Manish Rangankar <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-Upstream > <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>; James E.J. Bottomley > <jejb@xxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; > open list:QLOGIC QL41xxx ISCSI DRIVER <linux-scsi@xxxxxxxxxxxxxxx> > Subject: [EXT] [PATCH 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting > > External Email > > ---------------------------------------------------------------------- > The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the > following warning: > > drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type 'char' but > the argument has type 'int' [-Wformat] > rc = snprintf(buf, 3, "%hhd\n", SYSFS_FLAG_FW_SEL_BOOT); > > Fix this to use %d since this is a plain integer. > > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > --- > drivers/scsi/qedi/qedi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index > f1c933070884..367a0337b53e 100644 > --- a/drivers/scsi/qedi/qedi_main.c > +++ b/drivers/scsi/qedi/qedi_main.c > @@ -2254,7 +2254,7 @@ qedi_show_boot_tgt_info(struct qedi_ctx *qedi, int > type, > mchap_secret); > break; > case ISCSI_BOOT_TGT_FLAGS: > - rc = snprintf(buf, 3, "%hhd\n", SYSFS_FLAG_FW_SEL_BOOT); > + rc = snprintf(buf, 3, "%d\n", SYSFS_FLAG_FW_SEL_BOOT); > break; > case ISCSI_BOOT_TGT_NIC_ASSOC: > rc = snprintf(buf, 3, "0\n"); > -- > 2.25.1 SYSFS_FLAG_FW_SEL_BOOT is always going to have value 2, that's why it is given %hhd to limit the size to 1 byte. Is there other way to suppress this warning, such as typecasting or any other ?
