On Tue, 29 May 2007, Christoph Hellwig wrote:
> > +/*
> > + * copy data from device into scatter/gather buffer
> > + */
> > +static int fill_from_dev_buffer(struct scsi_cmnd *cmd, const void *buf,
> > + int buflen)
> > +{
> > + int k, req_len, act_len, len, active;
> > + void *kaddr;
> > + struct scatterlist *sgpnt;
> > +
> > + if (!cmd->request_bufflen)
> > + return 0;
> > +
> > + if (!cmd->request_buffer)
> > + return DID_ERROR << 16;
> > +
> > + if (cmd->sc_data_direction != DMA_BIDIRECTIONAL &&
> > + cmd->sc_data_direction != DMA_FROM_DEVICE)
> > + return DID_ERROR << 16;
> > +
> > + if (!cmd->use_sg) {
> > + req_len = cmd->request_bufflen;
> > + act_len = min(req_len, buflen);
> > + memcpy(cmd->request_buffer, buf, act_len);
> > + cmd->resid = req_len - act_len;
> > + return 0;
> > + }
>
> This is never true anymore.
Just to be sure: all four if-cases or only the last one?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@xxxxxxxxxxx ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
