On Thu, 18 Nov 2021 11:49:00 +0300, Dan Carpenter wrote: > The "item" pointer is always going to be valid pointer and does not > need to be checked. > > But if "item" were NULL then item_to_lun() would not return a NULL, but > instead, the container_of() pointer math would return a value in the > error pointer range. This confuses static checkers since it looks like > a NULL vs IS_ERR() bug. > > [...] Applied to 5.16/scsi-fixes, thanks! [1/1] target/configfs: delete unnecessary checks for NULL https://git.kernel.org/mkp/scsi/c/9c6603e1faf8 -- Martin K. Petersen Oracle Linux Engineering