Commit 598a90f2002c4 ("scsi: qla2xxx: add ring buffer for tracing debug
logs") introduced unconditional log string formatting to ql_dbg() even
if ql_dbg_log event is disabled. It harms performance because some
strings are formatted in fastpath and/or interrupt context.
Cc: Rajan Shanmugavelu <rajan.shanmugavelu@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Fixes: 598a90f2002c4 ("scsi: qla2xxx: add ring buffer for tracing debug logs")
Signed-off-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
---
drivers/scsi/qla2xxx/qla_dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 25549a8a2d72..7cf1f78cbaee 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -2491,6 +2491,9 @@ ql_dbg(uint level, scsi_qla_host_t *vha, uint id, const char *fmt, ...)
struct va_format vaf;
char pbuf[64];
+ if (!ql_mask_match(level) && !trace_ql_dbg_log_enabled())
+ return;
+
va_start(va, fmt);
vaf.fmt = fmt;
--
2.33.1
