Re: [PATCH] scsi: ufs: ufs-mediatek: add put_device() after of_find_device_by_node()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/10/21 6:51 PM, cgel.zte@xxxxxxxxx wrote:
From: Ye Guojin <ye.guojin@xxxxxxxxxx>

This was found by coccicheck:
./drivers/scsi/ufs/ufs-mediatek.c, 211, 1-7, ERROR missing put_device;
call of_find_device_by_node on line 1185, but without a corresponding
object release within this function.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Ye Guojin <ye.guojin@xxxxxxxxxx>
---
  drivers/scsi/ufs/ufs-mediatek.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index fc5b214347b3..5393b5c9dd9c 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -1189,6 +1189,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
  	}
  	link = device_link_add(dev, &reset_pdev->dev,
  		DL_FLAG_AUTOPROBE_CONSUMER);
+	put_device(&reset_pdev->dev);


Thanks for fix this missing.
Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>


  	if (!link) {
  		dev_notice(dev, "add reset device_link fail\n");
  		goto skip_reset;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux