From: Boaz Harrosh <bharrosh@xxxxxxxxxxx> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Thu, 24 May 2007 19:37:06 +0300 > FUJITA Tomonori wrote: > >> FUJITA Tomonori wrote: > > > > One thing that I found is: > > > > +#define scsi_resid(cmd) ((cmd)->sg_table->resid) > > > > > > This doesn't work for some drivers (at least ipr) since they set > > cmd->resid even with commands without data transfer. > > > > James, Tomo. > > the last accessor: > +#define scsi_resid(cmd) ((cmd)->resid) > > used as an l-value in drivers does not serve our purpose, as seen by the test > implementation of scsi_sg_table. Now clearly this needs an accessor and it is a > bidi parameter (need 2 of them). I thought that it would be better to fix several drivers (less than 10). - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
