On 11/3/21 9:33 AM, Christoph Hellwig wrote:
On Wed, Nov 03, 2021 at 10:37:30AM +0200, Adrian Hunter wrote:
The UFS driver does not issue device commands to the block layer.
blk_get_request() is used only to get a free slot.
That is indeed the case for the code touched here, but not in general:
ch@brick:~/work/linux$ git-grep blk_execute_rq drivers/scsi/ufs/
drivers/scsi/ufs/ufshcd.c: blk_execute_rq_nowait(/*bd_disk=*/NULL, req, /*at_head=*/true,
drivers/scsi/ufs/ufshpb.c: blk_execute_rq_nowait(NULL, req, 1, ufshpb_umap_req_compl_fn);
drivers/scsi/ufs/ufshpb.c: blk_execute_rq_nowait(NULL, req, 1, ufshpb_map_req_compl_fn);
Hi Christoph,
The blk_execute_rq_nowait() call in drivers/scsi/ufs/ufshcd.c will disappear
from Linus' master branch once Linus merges the v5.16 scsi core pull request.
See also the following patch authored by myself: "[PATCH 2/2] scsi: ufs: Stop
clearing unit attentions"
(https://lore.kernel.org/linux-scsi/20211001182015.1347587-3-jaegeuk@xxxxxxxxxx/).
Thanks,
Bart.
