On Wed, Nov 03, 2021 at 09:39:32AM -0700, Bart Van Assche wrote: > How about changing the blk_mq_alloc_request() / blk_put_request() calls in > ufshcd_exec_dev_cmd() and __ufshcd_issue_tm_cmd() into > scsi_{get,put}_internal_command() calls once Hannes' patch series that > introduces these functions is upstream? See also "[PATCH 03/18] scsi: add > scsi_{get,put}_internal_cmd() helper" > (https://lore.kernel.org/linux-scsi/20210503150333.130310-4-hare@xxxxxxx/). > See also patch "[PATCH 10/18] scsi: implement reserved command handling" > (https://lore.kernel.org/linux-scsi/20210503150333.130310-11-hare@xxxxxxx/). Well, if they don't even need the command at all an API that just returns the tag might be even better. But yes, we need some SCSI layer abstraction and Hannes and John are currently looking into that.