Re: [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: Re: [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk()
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 3 Nov 2021 17:04:51 +0100
Cc: axboe@xxxxxxxxx, hch@xxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, vishal.l.verma@xxxxxxxxx, dave.jiang@xxxxxxxxx, ira.weiny@xxxxxxxxx, richard@xxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, efremov@xxxxxxxxx, song@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, hare@xxxxxxx, jack@xxxxxxx, ming.lei@xxxxxxxxxx, tj@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20211103122157.1215783-4-mcgrof@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Nov 03, 2021 at 05:21:47AM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.

Look good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v2 00/13] block: add_disk() error handling stragglers
  - From: Luis Chamberlain
- [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk()
  - From: Luis Chamberlain

Prev by Date: Re: [PATCH v2 02/13] nvdimm/btt: use goto error labels on btt_blk_init()
Next by Date: Re: [PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures
Previous by thread: [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk()
Next by thread: Re: [PATCH v2 00/13] block: add_disk() error handling stragglers
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]