Re: [PATCH] scsi: ufs: clean up the Kconfig file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart--

On 10/24/21 6:17 PM, Bart Van Assche wrote:
On 10/24/21 16:35, Randy Dunlap wrote:
On 10/24/21 2:29 PM, Bart Van Assche wrote:
On 10/23/21 23:43, Randy Dunlap wrote:
        sure that you know the name of your UFS host adapter (the card
        inside your computer that "speaks" the UFS protocol, also
        called UFS Host Controller), because you will be asked for it.
@@ -51,7 +50,7 @@ config SCSI_UFSHCD
        (the one containing the directory /) is located on a UFS device.
  config SCSI_UFSHCD_PCI
-    tristate "PCI bus based UFS Controller support"
+    tristate "PCI bus-based UFS Controller support"

Even with this change applied capitalization is inconsistent.

I don't doubt it, but could you be more explicit about
which word(s) you mean, please?

I see one "pci" in the Kconfig file.

I changed that one. ^^^

I see several "Controller" vs. "controller."
I see a few of "Support" vs. "support."

Which are you referring to? (or something else)

I was referring to the word "Controller". Although English is not my native
language, shouldn't "UFS Controller" be changed into "UFS controller" since
neither "bus-based" nor "support" are capitalized?

That's not so clear to me, but then I don't have access to the UFS specs.

This help text:
	  UFS host adapter (the card
	  inside your computer that "speaks" the UFS protocol, also
	  called UFS Host Controller)

might imply that the spec calls it "UFS Host Controller", but I can't
read it (AFAIK). OTOH, if that's just a common (non-spec) name for it,
then yes, it should be in lower case ("controller").

I'm leaning towards using "controller" everywhere -- or not changing
any of them. :)
Oh well.

Do you have any insights into this?

thanks.
--
~Randy



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux