From: Jackie Liu <liuyun01@xxxxxxxxxx> When the value of error is printed, it will always be 0. Here, we should be print the correct error code when scsi_bsg_register_queue fails. Fixes: ead09dd3aed5 ("scsi: bsg: Simplify device registration") Cc: Jens Axboe <axboe@xxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Jackie Liu <liuyun01@xxxxxxxxxx> --- v1->v2: resend to linux-scsi mail list. drivers/scsi/scsi_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 86793259e541..d8789f6cda62 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -1379,6 +1379,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) * We're treating error on bsg register as non-fatal, so * pretend nothing went wrong. */ + error = PTR_ERR(sdev->bsg_dev); sdev_printk(KERN_INFO, sdev, "Failed to register bsg queue, errno=%d\n", error); -- 2.25.1