On 10/19/21 11:33 PM, Christoph Hellwig wrote: > On Wed, Oct 20, 2021 at 12:05:24AM -0400, Martin K. Petersen wrote: >> >> Christoph, >> >>> The changes to support pktcdvd are a bit ugly, but I can't think of >>> anything better (except for removing the driver entirely). If we'd >>> want to support packet writing today it would probably live entirely >>> inside the sr driver. >> >> Yeah, I agree. >> >> Anyway. No major objections from me. Not sure whether it makes most >> sense for this to go through block or scsi? > > I'm not sure either, but either tree is fine with me. Looks fine to me, outside of the spelling error in patch 1. I can set up a topic branch for this one. Christoph, can you do a resend with the enum naming fixed? -- Jens Axboe