From: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx> Fixes the following smatch warning: drivers/scsi/megaraid/megaraid_mbox.c:715 megaraid_init_mbox() warn: returning -1 instead of -ENOMEM is sloppy. Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> Fixes: dd00cc486ab1 ("some kmalloc/memset ->kzalloc (tree wide)") Signed-off-by: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx> --- drivers/scsi/megaraid/megaraid_mbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 14f930d27ca1..d98b223eab9a 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -712,7 +712,8 @@ megaraid_init_mbox(adapter_t *adapter) * controllers */ raid_dev = kzalloc(sizeof(mraid_device_t), GFP_KERNEL); - if (raid_dev == NULL) return -1; + if (raid_dev == NULL) + return -ENOMEM; /* -- 2.19.1.6.gb485710b