> > +static int exynosauto_ufs_vh_link_startup_notify(struct ufs_hba *hba, > > + enum > > +ufs_notify_change_status status) { > > + if (status == POST_CHANGE) { > > + ufshcd_set_link_active(hba); > > + ufshcd_set_ufs_dev_active(hba); > > + hba->wlun_dev_clr_ua = true; > wlun_dev_clr_ua no longer exists - needs rebase I found the commit. I'll remove this next patch. > > > + } > > + > > + return 0; > > +} > > + > > +static int exynosauto_ufs_vh_wait_ph_ready(struct ufs_hba *hba) { > > + u32 mbox; > > + ktime_t start, stop; > > + > > + start = ktime_get(); > > + stop = ktime_add(start, ms_to_ktime(PH_READY_TIMEOUT_MS)); > > + > > + do { > > + mbox = ufshcd_readl(hba, PH2VH_MBOX); > > + if ((mbox & MH_MSG_MASK) == MH_MSG_PH_READY) > > + return 0; > Maybe add a comment here that the mbox protocol will be defined later. Put some comments with TODO: tag. Best Regards, Chanho Park