Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
From: Anand Jain <anand.jain@xxxxxxxxxx>
Date: Wed, 13 Oct 2021 15:08:48 +0800
Cc: Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx
In-reply-to: <20211013051042.1065752-12-hch@lst.de>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 13/10/2021 13:10, Christoph Hellwig wrote:

Use the proper helper to read the block device size.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Looks good.

Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
  - From: Christoph Hellwig