On Mon, 2021-10-11 at 19:15 -0400, docfate111 wrote: > linux-scsi@xxxxxxxxxxxxxxx, > linux-kernel@xxxxxxxxxxxxxxx, > martin.petersen@xxxxxxxxxx > Bcc: > Subject: [PATCH] scsi_lib fix the NULL pointer dereference > Reply-To: > > scsi_setup_scsi_cmnd should check for the pointer before > scsi_command_size dereferences it. Have you seen this? As in do you have a trace? This should be an impossible condition, so we need to see where it came from. The patch as proposed is not right, because if something is setting cmd_len without setting the cmnd pointer we need the cause fixed rather than applying a band aid in scsi_setup_scsi_cmnd(). James