>>> Joe Perches <joe@xxxxxxxxxxx> schrieb am 09.10.2021 um 05:14 in Nachricht <5daf69b365e23ceecee911c4d0f2f66a0b9ec95c.camel@xxxxxxxxxxx>: > On Sat, 2021-10-09 at 11:02 +0800, Guo Zhi wrote: >> Pointers should be printed with %p or %px rather than >> cast to (unsigned long long) and printed with %llu. >> Change %llu to %p to print the pointer into sysfs. > ][] >> diff --git a/drivers/scsi/scsi_transport_iscsi.c > b/drivers/scsi/scsi_transport_iscsi.c > [] >> @@ -129,8 +129,8 @@ show_transport_handle(struct device *dev, struct > device_attribute *attr, >> >> >> if (!capable(CAP_SYS_ADMIN)) >> return -EACCES; >> - return sysfs_emit(buf, "%llu\n", >> - (unsigned long long)iscsi_handle(priv->iscsi_transport)); >> + return sysfs_emit(buf, "%p\n", >> + iscsi_ptr(priv->iscsi_transport)); > > iscsi_transport is a pointer isn't it? > > so why not just > > return sysfs_emit(buf, "%p\n", priv->iscsi_transport); Isn't the difference that %p outputs hex, while %u outputs decimal? > > ? > > -- > You received this message because you are subscribed to the Google Groups > "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to open-iscsi+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit > https://groups.google.com/d/msgid/open-iscsi/5daf69b365e23ceecee911c4d0f2f66a > 0b9ec95c.camel%40perches.com.
