Hey Bart, On Wed, Sep 29, 2021 at 03:04:37PM -0700, Bart Van Assche wrote: > Conditional statements are faster than indirect calls. Use a member variable > to track the SCSI command submitter such that later patches can call > scsi_done(scmd) instead of scmd->scsi_done(scmd). > > The asymmetric behavior that scsi_send_eh_cmnd() sets the submission > context to the SCSI error handler and that it does not restore the > submission context to the SCSI core is retained. > > Cc: Hannes Reinecke <hare@xxxxxxxx> > Cc: Ming Lei <ming.lei@xxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > drivers/scsi/scsi_error.c | 18 +++++++----------- > drivers/scsi/scsi_lib.c | 10 ++++++++++ > drivers/scsi/scsi_priv.h | 1 + > include/scsi/scsi_cmnd.h | 7 +++++++ > 4 files changed, 25 insertions(+), 11 deletions(-) > I think its good! Reviewed-by: Benjamin Block <bblock@xxxxxxxxxxxxx> -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
