RE: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver 8.59.1.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Jakub for reviewing this patch series. 


> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Thursday, September 30, 2021 12:08 AM
> To: Prabhakar Kushwaha <pkushwaha@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx; Ariel Elior <aelior@xxxxxxxxxxx>; Shai Malin
> <smalin@xxxxxxxxxxx>; Javed Hasan <jhasan@xxxxxxxxxxx>; Manish
> Rangankar <mrangankar@xxxxxxxxxxx>; prabhakar.pkin@xxxxxxxxx;
> malin1024@xxxxxxxxx; Omkar Kulkarni <okulkarni@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver
> 8.59.1.0
> 
> On Wed, 29 Sep 2021 15:12:07 +0300 Prabhakar Kushwaha wrote:
> > The qed_mfw_hsi.h contains HSI (Hardware Software Interface) changes
> > related to management firmware. It has been updated to support new FW
> > version 8.59.1.0 with below changes.
> >  - New defines for VF bitmap.
> >  - fec_mode and extended_speed defines updated in struct eth_phy_cfg.
> >  - Updated structutres lldp_system_tlvs_buffer_s, public_global,
> >    public_port, public_func, drv_union_data, public_drv_mb
> >    with all dependent new structures.
> >  - Updates in NVM related structures and defines.
> >  - Msg defines are added in enum drv_msg_code and fw_msg_code.
> >  - Updated/added new defines.
> >
> > This patch also fixes the existing checkpatch warnings and few important
> > checks.
> >
> > Signed-off-by: Ariel Elior <aelior@xxxxxxxxxxx>
> > Signed-off-by: Omkar Kulkarni <okulkarni@xxxxxxxxxxx>
> > Signed-off-by: Shai Malin <smalin@xxxxxxxxxxx>
> > Signed-off-by: Prabhakar Kushwaha <pkushwaha@xxxxxxxxxxx>
> 
> drivers/net/ethernet/qlogic/qed/qed_main.c:102:18: warning:
> ‘qed_mfw_ext_20g’ defined but not used [-Wunused-const-variable=]
>   102 | static const u32 qed_mfw_ext_20g[] __initconst = {
>       |                  ^~~~~~~~~~~~~~~
> 
> 
> Plus you add a whole bunch on kdoc warnings with those patches.
> Please make sure no new kdoc warnings and no new compilation warnings
> (with C=1 W=1 flags!)

Sorry from our side. 

Let me fix this and share v2 for review. 

--pk





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux