From: Boaz Harrosh <bharrosh@xxxxxxxxxxx> Subject: Re: [PATCH v2] add bidi support for block pc requests Date: Thu, 17 May 2007 11:49:37 +0300 > FUJITA Tomonori wrote: > > From: Jens Axboe <jens.axboe@xxxxxxxxxx> > > Subject: Re: [PATCH v2] add bidi support for block pc requests > > Date: Thu, 17 May 2007 07:48:13 +0200 > > > >> On Thu, May 17 2007, FUJITA Tomonori wrote: > >>> From: Jens Axboe <jens.axboe@xxxxxxxxxx> > >>> Subject: Re: [PATCH v2] add bidi support for block pc requests > >>> Date: Wed, 16 May 2007 19:53:22 +0200 > >>> > >>>> On Wed, May 16 2007, Boaz Harrosh wrote: > >>>>> now there are 2 issues with this: > >>>>> 1. Even if I do blk_queue_max_phys_segments(q, 127); I still get > >>>>> requests for use_sg=128 which will crash the kernel. > >>>> That sounds like a serious issue, it should definitely not happen. Stuff > >>>> like that would bite other drivers as well, are you absolutely sure that > >>>> is happening? Power-of-2 bug in your code, or in the SCSI code? > >>> Boaz, how do you send requests to the scsi-ml, via fs, sg, or bsg? > > These are regular fs (ext3) requests during bootup. The machine will not > boot. (Usually from the read ahead code) > Don't believe me look at the second patch Over Tomo's cleanup. > If I define SCSI_MAX_SG_SEGMENTS to 127 it will crash even when I > did in code: > blk_queue_max_phys_segments(q, SCSI_MAX_SG_SEGMENTS); > I suppose someone is looking at a different definition. Or there is > another call I need to do for this to work. ata_scsi_slave_config? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
