On Fri, Sep 24, 2021 at 04:26:35PM -0700, Bart Van Assche wrote: > --- a/include/scsi/scsi_device.h > +++ b/include/scsi/scsi_device.h > @@ -226,6 +226,8 @@ struct scsi_device { > > struct device sdev_gendev, > sdev_dev; > + struct attribute_group gendev_first_attr_group; > + const struct attribute_group *gendev_attr_groups[6]; Where does 6 come from? > struct execute_work ew; /* used to get process context on put */ > struct work_struct requeue_work; > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index 5afdc094a445..aa1207ab9d2e 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -481,7 +481,7 @@ struct scsi_host_template { > /* > * Pointer to the SCSI device properties for this host, NULL terminated. > */ > - struct device_attribute **sdev_attrs; > + struct attribute **sdev_attrs; Same here, "const struct attribute_group **groups;" ? thanks, greg k-h