On 9/24/21 11:59 AM, Avri Altman wrote:
Since fragment 'SCSI_UFS_HWMON' can't be build as a module, 'SCSI_UFS_HWMON' has to depend on 'HWMON=y'. Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification support") Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx> --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index 565e8aa6319d..30c6edb53be9 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -202,7 +202,7 @@ config SCSI_UFS_FAULT_INJECTION config SCSI_UFS_HWMON bool "UFS Temperature Notification" - depends on SCSI_UFSHCD && HWMON + depends on SCSI_UFSHCD && HWMON=y help This provides support for UFS hardware monitoring. If enabled, a hardware monitoring device will be created for the UFS device.
Thinking about this, it should be possible to do it like this so that both SCSI_UFSHCD=m ad SCSI_HFS_HWMON=m would also work. I.e., this would allow more combinations of Kconfig settings to work. It only excludes SCSI_UFSH_HWMON=y and HWMON=m + depends on SCSI_UFSHCD=HWMON || HWMON=y OK, I have verified that this works (builds) in all allowed combinations. Anders, would you please resubmit the patch? -- ~Randy
