From: Brian King <brking@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 3/19] ipr: convert to use the data buffer accessors
Date: Mon, 14 May 2007 10:27:44 -0500
> FUJITA Tomonori wrote:
> > @@ -550,12 +550,7 @@ struct ipr_cmnd *ipr_get_free_ipr_cmnd(s
> > static void ipr_unmap_sglist(struct ipr_ioa_cfg *ioa_cfg,
> > struct ipr_cmnd *ipr_cmd)
> > {
> > - struct scsi_cmnd *scsi_cmd = ipr_cmd->scsi_cmd;
> > -
> > - if (ipr_cmd->dma_use_sg)
> > - pci_unmap_sg(ioa_cfg->pdev, scsi_cmd->request_buffer,
> > - scsi_cmd->use_sg,
> > - scsi_cmd->sc_data_direction);
> > + scsi_dma_unmap(&ioa_cfg->pdev->dev, ipr_cmd->scsi_cmd);
> > }
>
> You can completely do away with ipr_unmap_sglist and just call
> scsi_dma_unmap directly instead.
I see. I'll update the patch.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
