On 9/17/21 2:31 PM, Avri Altman wrote:
- __ufshcd_transfer_req_compl(hba, pos,
/*retry_requests=*/true);
+ __ufshcd_transfer_req_compl(hba, 1U << pos,
+ false);
1) Maybe a word in the commit log about changing retry_requests from true to false.
2) Also while at it, maybe change u32 pos to u8 tag?
3) Add an unsigned long pending_reqs, add the tag inside the loop,
And call __ufshcd_transfer_req_compl(hba, pending_reqs, false) one time outside the loop.
Hi Avri,
While working on this patch I realized that commit c11a1ae9b8f6
("scsi: ufs: Add fault injection support") is not necessary.
ufshcd_prepare_req_desc_hdr() initializes the command status to
OCS_INVALID_COMMAND_STATUS and ufshcd_transfer_rsp_status()
translates that status code into DID_REQUEUE. I'm considering to
revert commit c11a1ae9b8f6.
I prefer not to change "u32 pos" into "u8 tag", otherwise backporting
this patch would become harder than necessary.
Is (3) important to you? I don't think that calls to
ufshcd_eh_device_reset_handler() are that common so performance
probably is not that important in this function.
Thanks,
Bart.
