On 13/05/07 18:48, James Bottomley wrote:
On Sun, 2007-05-13 at 18:42 +0100, Simon Arlott wrote:
If you set CONFIG_MODULE=y and build SCSI we assume you could have a
SCSI driver module at some point, which would necessitate the wait scan
module.
This should be implemented like "Library routines" and only added if such
a SCSI driver module is actually selected. Why can't it at least be a
visible option in the menu? (Although even then it looks like it's
impossible to disable).
There's out of tree modules to consider.
Ok, I propose we make dozens of modules default 'm' in case an out of
tree module requires it.
SCSI_SCAN_ASYNC ("Asynchronous SCSI scanning"): "You can load the
scsi_wait_scan module to ensure that all scans have completed."
It looks like SCSI_WAIT_SCAN is pointless unless SCSI_SCAN_ASYNC
is selected - so it should depend on it:
---
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index e62d23f..0f6c370 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -244,7 +244,7 @@ config SCSI_SCAN_ASYNC
config SCSI_WAIT_SCAN
tristate
default m
- depends on SCSI
+ depends on SCSI_SCAN_ASYNC
depends on MODULES
menu "SCSI Transports"
--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
