Re: [PATCH 0/4] scsi: remove last references to scsi_cmnd.tag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Russell

On 19/08/2021 09:40, Hannes Reinecke wrote:

The arm rpc_defconfig build is now broken on mainline.

I suggest resending this series, please.

Thanks

Hi all,

with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers
cannot reference the SCSI command tag anymore.
Arguably these drivers would have stopped working since 2010 with
the switch to block layer tags in SCSI anyway, so chances are no-one
had been using tagging in these drivers.

This patchset fixes up these usage; for fas216 we're just switching
to use the appropriate wrapper.
For acornscsi the tagged queue handling is removed altogether as it
was broken in the first place, and no-one since the switch to git
could be bothered to fix it.
And the patchset has the nice side-effect that we can remove the
scsi_device.current_tag field.

As usual, comments and reviews are welcome.

Hannes Reinecke (4):
   scsi: Introduct scsi_cmd_to_tag()
   fas216: kill scmd->tag
   acornscsi: remove tagged queuing vestiges
   scsi: remove 'current_tag'

  drivers/scsi/arm/Kconfig     |  11 ----
  drivers/scsi/arm/acornscsi.c | 103 ++++++++---------------------------
  drivers/scsi/arm/fas216.c    |  31 +++--------
  drivers/scsi/arm/queue.c     |   2 +-
  include/scsi/scsi_cmnd.h     |   7 +++
  include/scsi/scsi_device.h   |   1 -
  6 files changed, 38 insertions(+), 117 deletions(-)





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux