Hi Avri, I love your patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next next-20210910] [cannot apply to v5.14] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Avri-Altman/Add-temperature-notification-support/20210912-212110 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-kexec (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2aa54f753f44e119f4629ae015fedb3e12cebac6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Avri-Altman/Add-temperature-notification-support/20210912-212110 git checkout 2aa54f753f44e119f4629ae015fedb3e12cebac6 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): ld: drivers/scsi/ufs/ufs-sysfs.o: in function `ufs_hwmon_notify_event': >> drivers/scsi/ufs/ufshcd.h:1070: multiple definition of `ufs_hwmon_notify_event'; drivers/scsi/ufs/ufshcd.o:drivers/scsi/ufs/ufshcd.h:1070: first defined here ld: drivers/scsi/ufs/ufs-debugfs.o: in function `ufs_hwmon_notify_event': >> drivers/scsi/ufs/ufshcd.h:1070: multiple definition of `ufs_hwmon_notify_event'; drivers/scsi/ufs/ufshcd.o:drivers/scsi/ufs/ufshcd.h:1070: first defined here vim +1070 drivers/scsi/ufs/ufshcd.h 1062 1063 #ifdef CONFIG_SCSI_UFS_HWMON 1064 void ufs_hwmon_probe(struct ufs_hba *hba, u8 mask); 1065 void ufs_hwmon_remove(struct ufs_hba *hba); 1066 void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask); 1067 #else 1068 static inline void ufs_hwmon_probe(struct ufs_hba *hba, u8 mask) {} 1069 static inline void ufs_hwmon_remove(struct ufs_hba *hba) {} > 1070 void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask) {} 1071 #endif 1072 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
