Re: sd_spinup_disk() now is a little noisy

[Bart Van Assche <bvanassche@xxxxxxx>]

On 9/10/21 15:59, Heiner Kallweit wrote:
>   		do {
> +			u8 media_was_present = sdkp->media_present;

How about using 'bool' instead of 'u8'?

>   			cmd[0] = TEST_UNIT_READY;
>   			memset((void *) &cmd[1], 0, 9);
>   
> @@ -2138,7 +2140,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
>   			 * with any more polling.
>   			 */
>   			if (media_not_present(sdkp, &sshdr)) {
> -				sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n");
> +				if (media_was_present)
> +					sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n");
>   				return;
>   			}

Thanks,

Bart.