On Fri, Sep 03, 2021 at 05:27:26AM +0100, Christoph Hellwig wrote: > On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote: > > > > > > Just checking that was fine, and I notice how *many* places do that. > > > > > > Should the blk_execute_rq() function even take that "struct gendisk > > > *bd_disk" argument at all? > > No, it shouldn't. rq->rq_disk should go away and use rq->q->disk > instead. This has been on my TODO list, but didn't make the cut for > this merge window. Here is a quick draft of that: http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-remove-rq_disk
