It was against git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git branch "fixes". Looks like your changes resolve ->queue not being set prior to add_device(), please disregard my patch. It's not that critical to fix in earlier versions. Sorry for the noise. -Ewan On Thu, Sep 2, 2021 at 1:01 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Thu, Sep 02, 2021 at 12:24:25PM -0400, Ewan D. Milne wrote: > > Calling device_add() makes the scsi_disk visible in sysfs, the accessor > > routines reference sdkp->disk->queue which was not yet set properly. > > Fix this by initializing gendisk fields earlier in the function. > > What kernel is this against? This won't apply against linux-next > as disk->queue is now always set up by __blk_alloc_disk. >
