On 5/11/07, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
James Bottomley wrote:
...
> It strikes me that in all of this, we could also consider doing the DMA > mapping inside the mid layer (instead of in every driver). This is > essentially what libata is already doing ... leading to confusion in > SCSI drivers that use libata for SATA. > > So what do people think about this? The old SBP-2 driver needs the virtual addresses of S/G elements if compiled with a certain config option. This option is meant for use with FireWire controllers which do not implement OHCI-1394, or to run the IEEE 1394 stack in a more secure mode. However, sbp2 seems to be broken in multiple ways with this option at the moment, and I don't plan to fix it anytime soon. So in short, moving the DMA mapping into mid layer should also be fine with the old and the new SBP-2 driver.
Well, if we want to make a more secure mode for fw-sbp2.c where it, like the old driver, manually copies the payload data from the general async receive buffer to the destination, we'll still need the virtual address. How does the usb storage driver handle this? Kristian - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
