I haven't, sorry. I have run 5.x kernels on the hardware, and do have a set of patches kicking around for the SCSI drivers that do some cleanups. It looks like the fixup is pretty simple from the links you've sent - using scsi_cmd_to_rq() to get the tag. That said, I think I may only had one SCSI drive that came anywhere close to supported tagged queuing, so I never put much effort into tagged command support. Both acornscsi and fas216 have it disabled for this reason, so it's probably easier just to rip the tag code out of these drivers. Russell. On Fri, Aug 27, 2021 at 03:55:05PM +0100, John Garry wrote: > Hi Russell, > > Have you had a chance to consider the below? > > Thanks > > > > > > Recently we tried to remove scsi_cmnd.tags struct member [0]. > > > > However it now shows that some of the arm SCSI drivers continue to use > > this [1]. I think any other driver usage of this member had been found > > and removed. > > > > The impression is that the usage of scsi_cmnd.tag in those drivers is > > quite dubious. > > > > Now checking [2], it appears that you may have had some patches for > > these drivers locally. > > > > So is that the case? Is this HW still used with bleeding edge kernels? > > If so, can we fix up this tag management? > > > > [0] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@xxxxxxxxxx/T/#mb47909f38f35837686734369600051b278d124af > > > > > > [1] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@xxxxxxxxxx/T/#md5d786e5753083b2f3e8e761b1c69809f82c7485 > > > > > > [2] > > https://lore.kernel.org/lkml/20210109174357.GB1551@xxxxxxxxxxxxxxxxxxxxx/ > > > > Thanks, > > John > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
