On 8/19/21 10:37 PM, Adrian Hunter wrote:
On 19/08/21 9:14 pm, Bart Van Assche wrote:
On 8/19/21 2:35 AM, Adrian Hunter wrote:
* From SPC-6: the REQUEST SENSE command with any allocation length
- * clears the sense data.
+ * clears the sense data, but not all UFS devices behave that way.
*/
How about removing the comment entirely? Comprehending the above comment is not possible without reviewing the git history so I think it's better to remove it.
Perhaps a comment might stop someone tempted to remove the sense size in the future. What about:
/*
* Some UFS devices clear unit attention condition only if the sense
* size used (UFS_SENSE_SIZE in this case) is non-zero.
*/
That sounds good to me.
PS: we are working with the team that depends on this behavior (clearing
the unit attention condition) to implement a retry loop on top of
ioctl(SG_IO). Once that loop has been added it will be possible to drop
the code that clears the unit attention condition after a resume.
Thanks,
Bart.
