RE: [EXT] [PATCH 1/3] qla2xxx: Do not call fc_block_scsi_eh() during bus reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hannes,

> -----Original Message-----
> From: Hannes Reinecke <hare@xxxxxxx>
> Sent: Thursday, August 19, 2021 2:49 PM
> To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>; James Bottomley
> <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>; Nilesh Javali
> <njavali@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke
> <hare@xxxxxxx>
> Subject: [EXT] [PATCH 1/3] qla2xxx: Do not call fc_block_scsi_eh() during bus
> reset
> 
> External Email
> 
> ----------------------------------------------------------------------
> When calling bus reset the driver will be doing a full SAN resync
> anyway, so there is no need to wait for any pending RSCNs; they'll
> be re-issued during resync anyway.
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
>  drivers/scsi/qla2xxx/qla_os.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 868037c7d608..54254bd3a7d7 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1499,7 +1499,6 @@ static int
>  qla2xxx_eh_bus_reset(struct scsi_cmnd *cmd)
>  {
>  	scsi_qla_host_t *vha = shost_priv(cmd->device->host);
> -	fc_port_t *fcport = (struct fc_port *) cmd->device->hostdata;
>  	int ret = FAILED;
>  	unsigned int id;
>  	uint64_t lun;
> @@ -1515,15 +1514,6 @@ qla2xxx_eh_bus_reset(struct scsi_cmnd *cmd)
>  	id = cmd->device->id;
>  	lun = cmd->device->lun;
> 
> -	if (!fcport) {
> -		return ret;
> -	}
> -
> -	ret = fc_block_scsi_eh(cmd);
> -	if (ret != 0)
> -		return ret;
> -	ret = FAILED;
> -
>  	if (qla2x00_chip_is_down(vha))
>  		return ret;
> 
> --
> 2.29.2

Thanks for the patches.
Reviewed-by: Nilesh Javali <njavali@xxxxxxxxxxx>





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux