On 8/19/21 1:40 AM, Hannes Reinecke wrote:
+static inline u32 scsi_cmd_to_tag(struct scsi_cmnd *cmd) +{ + struct request *rq = scsi_cmd_to_rq(cmd); + + return rq->tag; +}
Do we really need this function? If so, please change "Introduct" in the subject into "Introduce". Additionally, how about renaming this function into scsi_cmd_tag()? How about changing the function body into "return scsi_cmd_to_rq(cmd)->tag"?
Thanks, Bart.