> -----Original Message----- > From: open-iscsi@xxxxxxxxxxxxxxxx [mailto:open-iscsi@xxxxxxxxxxxxxxxx] On > Behalf Of Herbert Xu > Sent: Wednesday, May 09, 2007 6:39 PM > To: Qi, Yanling > Cc: netdev@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; open- > iscsi@xxxxxxxxxxxxxxxx; linux-iscsi-devel@xxxxxxxxxxxxxxxxxxxxx; Qi, > Yanling; michaelc@xxxxxxxxxxx; dougg@xxxxxxxxxx; > James.Bottomley@xxxxxxxxxxxx > Subject: Re: SG_IO with >4k buffer size to iscsi sg device causes "Bad > page" panic > > > Qi, Yanling <Yanling.Qi@xxxxxxx> wrote: > > @@ -2571,6 +2572,13 @@ sg_page_malloc(int rqSz, int lowDma, int > > resp = (char *) __get_free_pages(page_mask, order); > > /* try half */ > > resSz = a_size; > > } > > + tmppage = virt_to_page(resp); > > + for( m = PAGE_SIZE; m < resSz; m += PAGE_SIZE ) > > + { > > + tmppage++; > > + SetPageReserved(tmppage); > > + } > > + > [Qi, Yanling] If I do a get_page() at sg_page_malloc() time and then do a put_page() at sg_page_free() time, I worry about a race condition that the page gets re-used before calling free_pages(). Thanks, Yanling - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
