Christoph Hellwig wrote: > On Thu, May 10, 2007 at 12:38:31PM +0200, Stefan Richter wrote: >> Would a BUG_ON(cmd->use_sg == 0); be in order? > > I don't think we should put this into every driver. If you want to > be sure this doesn't happen anymore put it just in front of the queuecommand > call. Thanks for the pointer. I'm just noticing that Jens Axboe has a patch which puts BUG_ON(!cmd->use_sg); into scsi_lib.c's sg table allocation path. (The "Chaining sg lists for bio IO commands v3" patchset from a few hours ago, part 11/13 "SCSI: support for allocating large scatterlists".) -- Stefan Richter -=====-=-=== -=-= -=-=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
