On 8/13/21 6:49 AM, John Garry wrote: > It is never read. Setting it and the request tag seems dodgy > anyway. This is done because there is code in the SCSI error handler that may allocate a SCSI command without allocating a tag. See also scsi_ioctl_reset(). > --- > drivers/scsi/fnic/fnic_scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c > index 0f9cedf78872..f8afbfb468dc 100644 > --- a/drivers/scsi/fnic/fnic_scsi.c > +++ b/drivers/scsi/fnic/fnic_scsi.c > @@ -2213,7 +2213,7 @@ fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc) > if (IS_ERR(dummy)) > return SCSI_NO_TAG; > > - sc->tag = rq->tag = dummy->tag; > + rq->tag = dummy->tag; > sc->host_scribble = (unsigned char *)dummy; Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
