Re: [PATCH 05/16] lpfc: Add EDC ELS support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James,

I love your patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v5.14-rc5 next-20210812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/James-Smart/lpfc-Update-lpfc-to-revision-14-0-0-1/20210813-101108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/500c94414bdcb236c244cbbde9219852777a38bf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review James-Smart/lpfc-Update-lpfc-to-revision-14-0-0-1/20210813-101108
        git checkout 500c94414bdcb236c244cbbde9219852777a38bf
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from drivers/scsi/lpfc/lpfc_els.c:45:
   drivers/scsi/lpfc/lpfc_els.c: In function 'lpfc_cmpl_els_edc':
>> drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:3947:5: note: in expansion of macro 'lpfc_printf_log'
    3947 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
   drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:3947:5: note: in expansion of macro 'lpfc_printf_log'
    3947 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
>> drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:3973:5: note: in expansion of macro 'lpfc_printf_log'
    3973 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
   drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:3973:5: note: in expansion of macro 'lpfc_printf_log'
    3973 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
   drivers/scsi/lpfc/lpfc_els.c: In function 'lpfc_els_rcv_edc':
>> drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:8806:5: note: in expansion of macro 'lpfc_printf_log'
    8806 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
   drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:8806:5: note: in expansion of macro 'lpfc_printf_log'
    8806 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
>> drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:8821:5: note: in expansion of macro 'lpfc_printf_log'
    8821 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~
   drivers/scsi/lpfc/lpfc_logmsg.h:94:45: warning: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Wformat=]
      94 |   dev_printk(level, &((phba)->pcidev)->dev, "%d:" \
         |                                             ^~~~~
   drivers/scsi/lpfc/lpfc_els.c:8821:5: note: in expansion of macro 'lpfc_printf_log'
    8821 |     lpfc_printf_log(
         |     ^~~~~~~~~~~~~~~


vim +94 drivers/scsi/lpfc/lpfc_logmsg.h

e8b62011d88d6f James Smart     2007-08-02  85  
dea3101e0a5c89 James Bottomley 2005-04-17  86  #define lpfc_printf_log(phba, level, mask, fmt, arg...) \
7f5f3d0d02aa2f James Smart     2008-02-08  87  do { \
f4b4c68f74dcd5 James Smart     2009-05-22  88  	{ uint32_t log_verbose = (phba)->pport ? \
f4b4c68f74dcd5 James Smart     2009-05-22  89  				 (phba)->pport->cfg_log_verbose : \
f4b4c68f74dcd5 James Smart     2009-05-22  90  				 (phba)->cfg_log_verbose; \
372c187b8a705c Dick Kennedy    2020-06-30  91  	if (((mask) & log_verbose) || (level[1] <= '3')) { \
372c187b8a705c Dick Kennedy    2020-06-30  92  		if ((mask) & LOG_TRACE_EVENT) \
372c187b8a705c Dick Kennedy    2020-06-30  93  			lpfc_dmp_dbg(phba); \
e8b62011d88d6f James Smart     2007-08-02 @94  		dev_printk(level, &((phba)->pcidev)->dev, "%d:" \

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux