Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Fri, 13 Aug 2021 03:19:41 +0100
Cc: Bart Van Assche <bvanassche@xxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Hannes Reinecke <hare@xxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
In-reply-to: <yq135rftlva.fsf@ca-mkp.ca.oracle.com>

On Wed, Aug 11, 2021 at 10:58:10PM -0400, Martin K. Petersen wrote:
> Thoughts?

Seems a bit verbose to me.

> -	qc = ata_qc_new_init(dev, scsi_cmd_to_rq(cmd)->tag);
> +	qc = ata_qc_new_init(dev, scsi_cmd_to_tag(cmd));

	qc = ata_qc_new_init(dev, scmd_tag(cmd));

would fit with scmd_printk(), scmd_id(), scmd_channel(), etc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v5 00/52] Remove the request pointer from struct scsi_cmnd
  - From: Bart Van Assche
- [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
  - From: Bart Van Assche
- Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
  - From: Hannes Reinecke
- Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
  - From: Bart Van Assche
- Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
  - From: Martin K. Petersen

Prev by Date: [PATCH 16/16] lpfc: Copyright updates for 14.0.0.1 patches
Next by Date: RE: [RFC PATCH v1 0/2] scsi: ufs: introduce vendor isr
Previous by thread: Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
Next by thread: Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]