Guenter, >> rval = qedi_ops->offload_conn(qedi->cdev, qedi_ep->handle, conn_info); >> if (rval) >> + /* delete doorbell from doorbell recovery mechanism */ >> + rval = qedi_ops->common->db_recovery_del(qedi->cdev, >> + qedi_ep->p_doorbell, >> + &qedi_ep->db_data); >> + >> QEDI_ERR(&qedi->dbg_ctx, "offload_conn returned %d, ep=%p\n", >> rval, qedi_ep); > > Due to missing { } this will now always result in QEDI_ERR() execution > (and possibly a C compiler warning). Fixed up. Thanks for spotting! -- Martin K. Petersen Oracle Linux Engineering