On Thu, 5 Aug 2021, Bart Van Assche wrote:
> Prepare for removal of the request pointer by using scsi_cmd_to_rq()
> instead. This patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Acked-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
Did you consider replacing rq_data_dir(cmd->request) with
cmd->sc_data_direction for this driver?
> ---
> drivers/scsi/NCR5380.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 3baadd068768..c6f76c25f6c1 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -778,7 +778,7 @@ static void NCR5380_dma_complete(struct Scsi_Host *instance)
> }
>
> #ifdef CONFIG_SUN3
> - if ((sun3scsi_dma_finish(rq_data_dir(hostdata->connected->request)))) {
> + if (sun3scsi_dma_finish(rq_data_dir(scsi_cmd_to_rq(hostdata->connected)))) {
> pr_err("scsi%d: overrun in UDC counter -- not prepared to deal with this!\n",
> instance->host_no);
> BUG();
> @@ -1710,7 +1710,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
> count = sun3scsi_dma_xfer_len(hostdata, cmd);
>
> if (count > 0) {
> - if (rq_data_dir(cmd->request))
> + if (rq_data_dir(scsi_cmd_to_rq(cmd)))
> sun3scsi_dma_send_setup(hostdata,
> cmd->SCp.ptr, count);
> else
> @@ -2158,7 +2158,7 @@ static void NCR5380_reselect(struct Scsi_Host *instance)
> count = sun3scsi_dma_xfer_len(hostdata, tmp);
>
> if (count > 0) {
> - if (rq_data_dir(tmp->request))
> + if (rq_data_dir(scsi_cmd_to_rq(tmp)))
> sun3scsi_dma_send_setup(hostdata,
> tmp->SCp.ptr, count);
> else
>
