RE: [PATCH] scsi: ufs: Remove useless if-state in ufshcd_add_command_trace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> From: Bean Huo <beanhuo@xxxxxxxxxx>
> 
> ufshcd_add_cmd_upiu_trace() will be called anyway, so move if-state down,
> make code simpler.
> 
> Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>


> ---
>  drivers/scsi/ufs/ufshcd.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> 064a44e628d6..02f54153fd6d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -380,14 +380,11 @@ static void ufshcd_add_command_trace(struct
> ufs_hba *hba, unsigned int tag,
>         if (!cmd)
>                 return;
> 
> -       if (!trace_ufshcd_command_enabled()) {
> -               /* trace UPIU W/O tracing command */
> -               ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> -               return;
> -       }
> -
>         /* trace UPIU also */
>         ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> +       if (!trace_ufshcd_command_enabled())
> +               return;
> +
>         opcode = cmd->cmnd[0];
>         lba = scsi_get_lba(cmd);
> 
> --
> 2.25.1





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux