On 02/08/2021 11:03, Damien Le Moal wrote: > +/** > + * sas_ncq_prio_supported_show - Indicate if device supports NCQ priority > + * @dev: pointer to embedded device > + * @attr: sas_ncq_prio_supported attribute desciptor > + * @buf: the buffer returned > + * > + * A sysfs 'read/write' sdev attribute, only works with SATA > + */ [...] > +static DEVICE_ATTR_RO(sas_ncq_prio_supported); > + Shouldn't that comment read: "A sysfs 'read only' sdev attribute, only works with SATA"