Re: [PATCH] scsi: lpfc: Fix typo in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Cai,

In general I am not a big fan of typo changes unless the string in
question is user-visible (printk, etc.). But if you must fix things,
please make sure the revised comments actually enhance clarity.
Mechanical changes ("the the" -> "the") rarely have the desired effect.

> @@ -2255,7 +2255,7 @@ static inline bool lpfc_rangecheck(uint val, uint min, uint max)
>  
>  /**
>   * lpfc_enable_bbcr_set: Sets an attribute value.
> - * @phba: pointer the the adapter structure.
> + * @phba: pointer the adapter structure.

Removing "the" does not really make that comment any easier to
understand. "Pointer the adapter structure" does not compute.

There are several occurrences of this typo.

> @@ -7827,7 +7827,7 @@ lpfc_els_rcv_rtv(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>   * @rrq: Pointer to the rrq struct.
>   *
>   * Build a ELS RRQ command and send it to the target. If the issue_iocb is
> - * Successful the the completion handler will clear the RRQ.
> + * Successful the completion handler will clear the RRQ.

I suspect the first "the" was supposed to be a "then".

> @@ -2285,7 +2285,7 @@ static void lpfc_sli4_fcf_pri_list_del(struct lpfc_hba *phba,
>   * @phba: pointer to lpfc hba data structure.
>   * @fcf_index: the index of the fcf record to update
>   * This routine acquires the hbalock and then set the LPFC_FCF_FLOGI_FAILED
> - * flag so the the round robin slection for the particular priority level
> + * flag so the round robin slection for the particular priority level

"slection" is not a word.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux